search

diskfs / go-diskfs

MIT License
515 stars 113 forks source link

Support to remove files #191

Open ludelion5 opened 11 months ago

ludelion5 commented 11 months ago

Hi, thanks for the awesome library.

I played around a bit with the library and was able to create new files and upate existing files on a fat32 partition inside an image. Unfortunately, there seems to be no support for removing files. Do I miss something? If its really missing, will the remove functionality come in the future?

Thanks and best regards

deitch commented 10 months ago

Right you are. Never got to implementing delete. Of course, some filesystems are read-only (iso and squashfs), so that would fail. And it supports mkdir and creating files and modifying partition tables on disks. But, yes, deleting never got created.

A contribution would be most welcome.

ludelion5 commented 8 months ago

Sorry for the late response, in the meantime I have implemented a remove and renaming feature supported by unit-tests. The patch-file was submitted to our open-source department in my company and will be checked, they will open a pull-request for you to review. Unfortunately, this might take some time. Hopefully everything works out and we can contribute to your library :-)

deitch commented 8 months ago

That would be great, thank you. I am sorry you have to go through the approvals rigamarole, but it isn't uncommon in large firms.