search

diskfs / go-diskfs

MIT License
515 stars 116 forks source link

ext4 read-only for now #218

Closed deitch closed 5 months ago

deitch commented 5 months ago

This is a first attempt at getting ext4 live. To get past some challenging parts, I am focusing on ext4 read-only first.

The current package filesystem/ext4/ does pass vet, and can compile. linting will require a lot more cleanup.

There are almost no tests on it, and it has not been tested manually.

Steps:

  1. Clean up the significant number of linting errors
  2. Get it to pass minimal current tests
  3. Write lots more unit tests, get them to pass
  4. Extend the integration tests, get them to pass
  5. Do manual testing
  6. Convert from draft to regular PR
shanduur commented 5 months ago

Great job! Is there any contribution that I might do to speed things up? E.g. adding tests, docs?

deitch commented 5 months ago

Yeah, thank you @shanduur . Tests are next. I would start with unit tests on small functions, as I am positive there are errors of calculation in various places.

FWIW, I do have the beginnings of write capability in a separate local branch, but we should get read working correctly first.

deitch commented 5 months ago

If it is just small things, comment on the PR. If it is wholesale additions or changes, just open a PR to the ext4 branch.

deitch commented 5 months ago

lint is clean, that is something. Now it needs tests, both unit and actual integration, to get it to actually work.

deitch commented 5 months ago

As far as I am concerned, ext4 read-only is ready. I am going to merge in as soon as CI is clean. ext4-write is for another day, although I have part of it, and may push out a branch.