diskfs / go-diskfs

MIT License
515 stars 116 forks source link

iso9660 and squashfs support for parallel writings #245

Closed deitch closed 3 months ago

deitch commented 3 months ago

Fixes #244

The iso finalization originally was written without parallelism in mind. Most of it works fine. The inly issue was walking the workspace to finalize. Because it is easier to work with relative paths, it did a os.Chdir(workspace) followed by a filepath.Walk(".",...). In most cases, this works fine, but if you run in parallel, different threads start changing the current directory and mess up things like creating files or removing files or walking trees.

In general, os.Chdir() is not a friendly thing to do in libraries, so it is good to remove it.

Both iso9660 and squashfs did this, so fixed in both places.

Thanks to @mchuang3 for the excellent issue in #244, with a simple recreation.