diskin-lab-chop / AutoGVP

19 stars 3 forks source link

Fix filter vcf script so first filtering criterion is applied #128

Closed rjcorb closed 1 year ago

rjcorb commented 1 year ago

Purpose/implementation Section

What feature is being added or bug is being addressed?

closes #127. There was a minor bug where the first filtering criterion was being skipped in filter_vcf.sh, due to the script searching for criterion starting in the 4th argument rather than the 3rd.

What was your approach?

Fixed loop so filtering criterion are searched for starting with 3rd argument.

What GitHub issue does your pull request address?

127

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Run test pbta sample using following command and confirm that filtering command includes all three criteria:

bash run_autogvp.sh --workflow="cavatica" \
--vcf=input/test_pbta.single.vqsr.filtered.vep_105.vcf \
--filter_criteria='INFO/AF>=0.2 INFO/DP>=15 (gnomad_3_1_1_AF_non_cancer<0.01|gnomad_3_1_1_AF_non_cancer=".")' \
--intervar=input/test_pbta.hg38_multianno.txt.intervar \
--multianno=input/test_pbta.hg38_multianno.txt \
--autopvs1=input/test_pbta.autopvs1.tsv \
--outdir=../results \
--out="test_pbta"

Is there anything that you want to discuss further?

No