What feature is being added or bug is being addressed?
Closes #154. This PR updates code to retain autopvs1 criterion column in final output, and replaces unadjusted evidence columns with autopvs1 adjusted columns
What was your approach?
Evidence column values from intervar adjusted data frame (combined_tab_with_vcf_intervar) were prioritized over those from unadjusted data frame (clinvar_anno_intervar_vcf_df)
criterion was added to output_colnames.tsv
What GitHub issue does your pull request address?
154
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please run updated code on custom and pbta test files, and check that criterion_autopvs1 column is retained in final output. Additionally, you can test that adjusted evidence columns are included by checking variants with criterion == "na" and "intervar_adjusted == "Yes"; these should all have PVS1_autogvp == 0.
Purpose/implementation Section
What feature is being added or bug is being addressed?
Closes #154. This PR updates code to retain autopvs1 criterion column in final output, and replaces unadjusted evidence columns with autopvs1 adjusted columns
What was your approach?
combined_tab_with_vcf_intervar
) were prioritized over those from unadjusted data frame (clinvar_anno_intervar_vcf_df
)criterion
was added tooutput_colnames.tsv
What GitHub issue does your pull request address?
154
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please run updated code on custom and pbta test files, and check that
criterion_autopvs1
column is retained in final output. Additionally, you can test that adjusted evidence columns are included by checking variants withcriterion == "na"
and"intervar_adjusted == "Yes"
; these should all havePVS1_autogvp == 0
.Is there anything that you want to discuss further?
No
Documentation Checklist