Closed rjcorb closed 1 year ago
Looks good to me! We'd just need to make sure we add this to the readme.
I just reviewed the README, and since we only show example usage for the full wrapper script execution (which already includes outdir argument), I think we are good.
Purpose/implementation Section
What feature is being added or bug is being addressed?
Closes #156. This PR adds an output directory argument that allows users to specify where output of
01-annotate_variants_*_input.R
and04-filter_gene_annotations.R
is written.What was your approach?
outdir
argument when executing 01 and 04 scripts inrun_autogvp.sh
outdir
to parsed parameters in 01 and 04 scriptsWhat GitHub issue does your pull request address?
156
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please run on test data set, and specify different
outdir
folders to check that updated code works as expected. For example:Is there anything that you want to discuss further?
No
Documentation Checklist