diskin-lab-chop / AutoGVP

19 stars 3 forks source link

add disease list, strategy options to select-clinVar-submissions.R #192

Closed rjcorb closed 1 year ago

rjcorb commented 1 year ago

Purpose/implementation Section

What feature is being added or bug is being addressed?

Closes #190. This PR updates select-clinVar-submissions.R to allow the following parameters:

What was your approach?

What GitHub issue does your pull request address?

190

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please check new code logic, and test run select-clinVar-submissions.R using all combinations of parameters. There currently isn't an option to specify name of output file, so the --outdir argument will need to be changed to save different output versions

No concept ID list provided: Rscript scripts/select-clinVar-submissions.R --variant_summary data/variant_summary.txt.gz --submission_summary data/submission_summary.txt.gz --outdir <out_dir>

Concept ID list provided, latest call strategy: Rscript scripts/select-clinVar-submissions.R --variant_summary data/variant_summary.txt.gz --submission_summary data/submission_summary.txt.gz --conceptID_list data/clinvar_cpg_concept_ids.tsv --conflict_res "latest" --outdir <out_dir>

Concept ID list provided, most severe strategy: Rscript scripts/select-clinVar-submissions.R --variant_summary data/variant_summary.txt.gz --submission_summary data/submission_summary.txt.gz --conceptID_list data/clinvar_cpg_concept_ids.tsv --conflict_res "most_severe" --outdir <out_dir>

Is there anything that you want to discuss further?

Does the current code logic agree with what was discussed in our group meeting?

9766/101811 (9.5%) of variants with conflicting interpretation currently have discordant final calls between the three runs shown above.

Documentation Checklist

rjcorb commented 1 year ago

@jharenza I have updated the wrapper bash script to include arguments necessary to run select-clinVar-submissions.R. This should be able to run under any conditions with the current conditional statements -- if variant_summary and submission_summary files not provided then they will be searched for, and if not found they will be downloaded to run the script. And default settings (no conceptID, resolve with latest date) will be assumed if not otherwise explicitly stated when running run_autogvp.sh

rjcorb commented 1 year ago

@jharenza I've updated the conditional statements and repo README. The -f and ! -e notation works for checking if files exist, but for check if a variable has a null value I used -z/-n (variable is null/ variable is not null). Another ChatGPT rec!