Open ghostbuster91 opened 7 months ago
Thanks for the repro.
I'm not sure whether this should be a smithy4s issue or http4s issue though. @kubukoz, thoughts ?
Smells like http4s...
ugh I was distracted when submitting the comment, should've elaborated a bit.
http4s appears to just have a single Raw header for an X-Foo
like the above, so we'd have to apply extra parsing on it. This seems to me like something that belongs in http4s, because in virtually every other area it gives us solid pre-parsed, structured representations of HTTP messages.
Let's open in http4s. I'm not opposed to fixing it here if they offer a rationale for why they shouldn't do it, but I'd rather we asked first
I opened an issue in http4s
According to the RFC:
It should be possible to send multiple values for a single header by passing them as comma separated list.
However,
SimpleRestJson
smithy4s treats all such values as a single text value.repository to reproduce: https://github.com/ghostbuster91/demos/tree/multi-header
calling the endpoint should return
{"weather":"2"}
but it returns:smithy4s version: 0.18.15