Open kubukoz opened 1 year ago
Wouldn't operation
s rendering also be affected if it's only struct
s?
good catch :) that's true.
Althouuuuugh... for operations, it's not really "operation members", but rather members of the input shape, which is 100% a struct. So the if
will probably still refer to structs
For collections, the content of the documentation is mostly correct, it's just that @param
is the wrong annotation. We just need to drop it in favour of a custom header.
Any suggestions for the header? I'd start with empty string.
Yeah that's fine. As long as Maps have got key
and value
, and list
have "member" or "content", it's all good
Another follow-up to #713.
We only check for unions here:
https://github.com/disneystreaming/smithy4s/blob/series/0.17/modules/codegen/src/smithy4s/codegen/internals/SmithyToIR.scala#L760-L780
I believe we should be stricter and only hit
else
ifshape
is a struct OR operation (see #772).Currently, it also matches:
enums
collections (lists/maps)