search

disorderedmaterials / dissolve

Structure refinement software for total scattering data
GNU General Public License v3.0
9 stars 16 forks source link

refactor: Remove custom analysis nodes #1931

Closed trisyoungs closed 2 weeks ago

trisyoungs commented 1 month ago

Since moving over to new developer-friendly analysis classes in #1789 and #1795 we no longer have need for the set of ProcedureNodes that were used in the analysis modules, nor the general-purpose AnalysisModule itself. Here we remove all of that.

Given the potentially low number (perhaps zero) of use cases in the user community this is not being flagged as a breaking change.

Closes #1877 (sort of!). Closes #1653.

trisyoungs commented 2 weeks ago

Well, this tidies up the codebase a bit! Looks good to me! I see that the documentation still remains for the various nodes + the Analyse module, is this intentional? 👍

I deliberately left this part for a follow-up PR which I thought I had already submitted to the stack, but apparently not! Must have left that somewhere special...