Remove use of ListItem base class

rprospero commented 4 years ago

The ListItem class is needed for every class that is stored in the custom List container. Removing references to ListItem allows us to progressively remove our dependence on the List class.

[x] ~src/base/charstring.h~
[x] src/base/geometry.h
[x] src/base/plainvalue.h
[x] src/base/processgroup.h
[x] src/classes/atomtype.h
[x] src/classes/atomtypedata.h
[x] src/classes/braggreflection.h
[x] src/classes/changedata.h
[x] src/classes/configuration.h
[x] src/classes/coordinateset.h
[x] src/classes/isotopedata.h
[x] src/classes/isotopologue.h
[x] src/classes/isotopologues.h
[x] src/classes/isotopologueset.h
[x] src/classes/isotopologueweight.h
[x] src/classes/kvector.h
[x] src/classes/masterintra.h
[x] src/classes/pairpotential.h
[x] src/classes/partialset.h
[x] src/classes/sitereference.h
[x] src/classes/sitestack.h
[x] src/classes/species.h
[x] src/classes/speciesatom.h
[x] src/classes/speciesinfo.h
[x] src/classes/speciesring.h
[x] src/classes/speciessite.h
[x] src/data/elementcolours.h
[x] src/data/ff.h
[x] src/data/ffangleterm.h
[x] src/data/ffatomtype.h
[x] src/data/ffbondterm.h
[x] src/data/ffimproperterm.h
[x] src/data/ffparameters.h
[x] src/data/fftorsionterm.h
[x] src/data/isotopes.h
[x] src/data/sg/generator.h
[x] src/expression/node.h
[x] src/genericitems/item.h
[x] src/gui/charts/chartblock.h
[x] src/gui/charts/charthotspot.h
[x] src/gui/configurationtab.h
[x] src/gui/gizmo.h
[x] src/gui/layertab.h
[x] src/gui/moduletab.h
[x] src/gui/referencepoint.h
[x] src/gui/render/primitive.h
[x] src/gui/render/primitiveassembly.h
[x] src/gui/render/primitiveinstance.h
[x] src/gui/render/renderable.h
[x] src/gui/render/renderablegroup.h
[x] src/gui/render/textformat.h
[x] src/gui/render/textfragment.h
[x] src/gui/render/textprimitive.h
[x] src/gui/speciestab.h
[x] src/gui/systemtemplate.h
[x] src/gui/widgets/mimestrings.h
[x] src/gui/wizardwidgethighlight.h
[x] src/gui/wizardwidgetpageinfo.h
[x] src/gui/workspacetab.h
[x] src/keywords/base.h
[x] src/keywords/group.h
[x] src/math/data1d.h
[x] src/math/data2d.h
[x] src/math/data3d.h
[x] src/math/histogram1d.h
[x] src/math/histogram2d.h
[x] src/math/histogram3d.h
[x] src/module/group.h
[x] src/module/layer.h
[x] src/module/module.h
[x] src/neta/node.h
[x] src/procedure/nodes/node.h
[x] src/procedure/nodes/nodereference.h
[x] src/templates/array.h
[x] src/templates/dynamicarray.h
[x] src/templates/factory.h
[x] src/templates/pair.h
[x] src/templates/vector3.h

This is part of pr #245

rprospero commented 4 years ago

PR #255 and #256 should trivially check off two of these boxes.

rprospero commented 3 years ago

We have removed the List class from Dissolve.

disorderedmaterials / dissolve

Remove use of ListItem base class #257