disorderedmaterials / dissolve

Structure refinement software for total scattering data
GNU General Public License v3.0
9 stars 16 forks source link

Remove MinimiserBase<T> #947

Closed trisyoungs closed 2 years ago

trisyoungs commented 2 years ago

Describe the feature / issue Minimisation algorithms (Monte Carlo, praxis etc.) are all built on a template class (MinimiserBase) which has a historically bad and unnecessary design.

Proposal is to remove the use of MinimiserBase completely and move to independent classes specific to each minimisation algorithm, and replace the use of cost function callbacks with lambdas.

rprospero commented 2 years ago

Closed in #976