run: fix signal handling - Githubissues

dispatchrun / dispatch

Entrypoint of the Dispatch ecosystem.

11 stars 1 forks source link

run: fix signal handling #75

Closed chriso closed 4 months ago

chriso commented 4 months ago

Changes to signal handling:

we spawn the child process in a new process group on macOS, like we were doing on Linux
we forward whatever signal was first received, rather than unconditionally sending SIGTERM
we forward the received signal to all processes in the process group

We're also now locking the OS thread before spawning the child process, to avoid issues with threads and Pdeathsig on Linux (this fixes https://github.com/dispatchrun/dispatch/issues/68).