dispatchrun / timecraft

The WebAssembly Time Machine
https://docs.timecraft.dev
GNU Affero General Public License v3.0
329 stars 7 forks source link

Decide whether inheriting all environment variables is the right model #167

Open achille-roussel opened 1 year ago

achille-roussel commented 1 year ago

During the early development of the project, we chose to automatically inherit the environment of the host in guest processes to simplify configuration and have a default that would serve well for fast iteration over the project development.

Now that the project matures, we may want to revisit those early design decisions.

chriso commented 1 year ago

For a nice balance of convenience and security, maybe the root process inherits the environment and disk access, but sub-processes that are spawned implicitly to handle tasks do not? The user can opt-out of the default root process access, and opt-in (via application code to spawn tasks) to passing environment variables and exposing parts of the file system?

achille-roussel commented 1 year ago

This seems like a good model to try out 👍