search

displague / deprecated-terraform-provider-linode

[OLD] Terraform provider plugin for Linode Cloud resources.. See
https://github.com/terraform-providers/terraform-provider-linode
Mozilla Public License 2.0
15 stars 5 forks source link

Use terraform compatible INFO,WARN,ERROR logging #11

Closed displague closed 5 years ago

displague commented 6 years ago

https://github.com/terraform-providers/terraform-provider-google/blob/97b8419ea56fbbbfc6e71275f92e81e24915777e/google/config.go#L151

displague commented 6 years ago

[INFO] and [WARN] are now being used.

In the Google provider I only found a few occurences of [ERROR] being used:

google/resource_composer_environment_test.go:                   return fmt.Errorf("[ERROR] Environment %q has invalid create time %q", e.Name, e.CreateTime)
google/resource_dataproc_cluster.go:            fmt.Printf("[ERROR] Attempting to delete autogenerated bucket (for dataproc cluster): Error deleting bucket %s: %v\n\n", bucket, err)
google/resource_dataproc_job_test.go:                           log.Printf("[ERROR] Job failed, driver logs:\n%s", body)
google/resource_google_project_iam_policy.go:           log.Printf("[ERROR] Could not unmarshal old policy %s: %v", old, err)
google/resource_google_project_iam_policy.go:           log.Printf("[ERROR] Could not unmarshal new policy %s: %v", new, err)

This may be a good fit for situations where parsing fails when we expect d.Get to provider a value that can be safely converted based on the TF schema.Type. Currently we return "Error parsing ..." or "Error converting ..."

displague commented 5 years ago

Closing this, noting that [ERROR] should be used in the future where relevant.