search

displague / vagrant-linode

A Vagrant plugin that adds a Linode provider to Vagrant, allowing Vagrant to control and provision Linodes.
MIT License
124 stars 23 forks source link

Rebuild action, implemented by destorying disks and profile and then … #67

Closed preluigi closed 8 years ago

preluigi commented 8 years ago

…recreate them

displague commented 8 years ago

Thanks for the PR!

displague commented 8 years ago

That create blob that was copied is the biggest refactor target. Copying it doubles the mess.

Could you consolidate the duplication in some way?

preluigi commented 8 years ago

I can consider that in my spare time; I'll let you know.

preluigi commented 8 years ago

I can consider that in my spare time; I'll let you know.

Luigi

On 25 October 2016 at 14:31, Marques Johansson notifications@github.com wrote:

That create blob that was copied is the biggest refactor target https://codeclimate.com/github/displague/vagrant-linode/VagrantPlugins::Linode::Actions::Create. Copying it doubles the mess.

Could you consolidate the duplication in some way?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/displague/vagrant-linode/pull/67#issuecomment-256021344, or mute the thread https://github.com/notifications/unsubscribe-auth/AHWWZpftGrCT3Ye3-P3-_EgZwlmaoGnGks5q3faygaJpZM4KefAH .