search

disqus / disqus-php

Disqus API bindings for PHP
http://disqus.com/api/
Apache License 2.0
149 stars 72 forks source link

Optimize Interfaces.json? #9

Open ProLoser opened 13 years ago

ProLoser commented 13 years ago

I realize this may seem a bit OCD, but I actually made an API parser plugin for CakePHP (haven't made a disqus one yet though). I made use of an 'api map' which is the equivalent to your interfaces file, however I had only 2 thoughts:

Wouldn't it reduce the footprint to 1. make the 'required' field optional and 2. group interfaces under the method type?

Here is one of my examples: https://github.com/ProLoser/CakePHP-Github/blob/master/config/github.php

Although there is extra information in there that I use but the main idea is the same, things are just grouped by CRUD.

Otherwise, feel free to close this ticket, it was just a thought that popped into my head reviewing your code for integration, heh.

dcramer commented 13 years ago

Both of the points are good:)

We'll be revisiting the interfaces.json very soon (as we update our plugins), so I'll keep this open for when we address that.