search

disqus / disqus-python

Disqus API bindings for Python
https://disqus.com/api/docs/
Apache License 2.0
165 stars 51 forks source link

Better handling for when an interface is not defined. #17

Closed dpetzold closed 4 years ago

dpetzold commented 10 years ago

Moved the https call out for easier use with mock. Removed pytest dependancy.

mattrobenolt commented 10 years ago

Why not pass an optional "client" through the constructor instead? I really don't like this approach. This is usually implemented by some sort of driver scenario and I can specify my own driver as long as it implements the expected interface. And you'd swap the driver in with a mock driver or something.

mattrobenolt commented 10 years ago

Can you just rebase and squash this so the history isn't all gross and stuff?

mattrobenolt commented 10 years ago

Also this conflicts with some of the stuff in HEAD. Like, the "version bump to 0.4.3" commit, and you added the assertRaises backport into a different directory, etc. This will just not be a pretty merge.

I'd suggest rebasing against HEAD and reapply your changes.