search

disqus / disqus-react

A React component for Disqus
MIT License
370 stars 46 forks source link

Make react a peer dependency #10

Closed IcanDivideBy0 closed 5 years ago

IcanDivideBy0 commented 6 years ago

I believe react / react-dom should be a peer dependency https://yarnpkg.com/blog/2018/04/18/dependencies-done-right

karl-run commented 6 years ago

@ryanvalentin Would be nice to get this merged in.

If this indeed supports React 16, it should be reflected in the peerDependencies as well, e.g:

  "peerDependencies": {
    "react": "^15.6.1 || ^16.0.0",
    "react-dom": "^15.6.1 || ^16.0.0"
  },
avinashjoshi commented 5 years ago

This package works with React 16.6.0 - Tested and using it currently in production.

tterb commented 5 years ago

@IcanDivideBy0 Sorry for the delay, merging this PR now.

Also, @karl-run I agree React 16 support should be reflected in the peerDependencies. I'm not able to edit this PR, but will be updating that in a separate PR. (#27)