disqus / disqus-react

A React component for Disqus
MIT License
369 stars 46 forks source link

DiscussionEmbed fails PropType Check for config Object, complains for String #113

Closed sysRoot closed 3 years ago

sysRoot commented 3 years ago

Disregard. I'm novice.

Describe the bug

DiscussionEmbed's config prop says it would like a string not an object, fails proptype check

To Reproduce

Run disqus-react as of 9/8/2021 @ 2PM EDT

Expected behavior

I expected Disqus-React's DiscussionEmbed to load, but config complained about it being an object, and that it should be a string. PropType check fails

Screenshots

image

Specifications:

Additional context

Add any other context about the problem here.

tterb commented 3 years ago

@sysRoot This is the expected behavior because the config.identifier is supposed to be a string.