search

disqus / gargoyle

Feature switches in Django
http://engineering.disqus.com
Apache License 2.0
746 stars 112 forks source link

throw exception when key longer than 64 characters #103

Closed switch87 closed 6 years ago

switch87 commented 8 years ago

I added a check on the length of gargoyle keys, this will prevent problems on SQL-databases with 'Strict SQL Mode' disabled.

switch87 commented 8 years ago

@mattrobenolt

adamchainz commented 8 years ago

Hi @switch87 , we considered merging this into the YPlan gargoyle fork, however because MySQL has many problems without strict mode active, and this only fixes one such problem, we don't think it's worth merging. Please check out my package Django-MySQL, which has a number of Django + MySQL improvements, including a check that recommends strict mode, plus a guide on how to activate it: https://django-mysql.readthedocs.org/en/latest/checks.html#django-mysql-w001-strict-mode .

Thanks!

switch87 commented 8 years ago

@nielsvanoch Django-MySQL is misschien wel interessant voor jullie, dit gaat nog over een probleem war ik bij jullie op gestoten was.