disqus / gargoyle

Feature switches in Django
http://engineering.disqus.com
Apache License 2.0
748 stars 112 forks source link

No feedback when switch key/label over 32 characters #2

Closed winhamwr closed 13 years ago

winhamwr commented 13 years ago

My first time trying out switch creating, I used a name that was more than 32 characters and nothing happened via the interface (it just hung). I saw there was a 500 via runserver, and it was a bit confusing. Looks like the issue is that the limit is 32 characters for both and there's no validation response.

dcramer commented 13 years ago

Ensure we verify length of of name and key values and return GargoyleExceptions for validation errors (closed by 5d0ef4722264e9fcfe8b39ccc1e676e63c33ae14)

winhamwr commented 13 years ago

Wonderful. Thanks