New setting GARGOYLE_CACHE_NAME to use with gargoyle.gargoyle

disqus / gargoyle

Feature switches in Django

http://engineering.disqus.com

Apache License 2.0

746 stars 112 forks source link

New setting GARGOYLE_CACHE_NAME to use with gargoyle.gargoyle #52

Closed estebistec closed 11 years ago

estebistec commented 11 years ago

Read a new setting, GARGOYLE_CACHE_NAME which, if defined, provides the named cache when the default gargoyle manager is created

The cache kwarg is used by the CachedDict base class

estebistec commented 11 years ago

Of course this new setting should be doc'd, but I don't see a clear place in the docs for it. The usage page? The manager ref page?

estebistec commented 11 years ago

One more note I should make about this pull request: I'm not adverse to just creating a new SwitchManager instance that does have the desired caching, but then, AFAICT, the template tags can't be told to use that manager.

estebistec commented 11 years ago

If this has no shot at getting merged feel free to just say so or close this. So far nothing I'm requesting is worth forking over, so I either get these smaller changes or not.

estebistec commented 11 years ago

Nice. Thanks! :)