disqus / gargoyle

Feature switches in Django
http://engineering.disqus.com
Apache License 2.0
748 stars 112 forks source link

Support for "all conditions must be true" #84

Open ghost opened 10 years ago

ghost commented 10 years ago

I've been working on support for this as we need it in my company. Can I get permission to create PRs?

mattrobenolt commented 10 years ago

You already have permission. This is a public project. Not sure what else you're looking for. --Matt Robenolt@mattrobenoltOn Mon, Jun 16, 2014 at 3:09 AM -0700, "AndersenTobias" notifications@github.com wrote:

I've been working on support for this as we need it in my company. Can I get permission to create PRs?

—Reply to this email directly or view it on GitHub.

ghost commented 10 years ago

@mattrobenolt I'm new to github, sorry.

How would this best be implemented? What do you think about having a require checkbox next to exclude? Then check if all required_conditions are satisfied. The others would be checked as usual with any, if there are any.