search

disqus / grunt-smartrev

A "smart" file versioner for production environments which takes inter-file dependencies into account automatically.
Apache License 2.0
75 stars 6 forks source link

Fix relative paths (fixes #5) #8

Closed benvinegar closed 10 years ago

benvinegar commented 10 years ago

The new test case (/test/fixtures/relative) creates a relative URL example for all supported content types: HTML, JS, CSS.

BYK commented 10 years ago

Doesn't play well with the baseUrl argument. Also I think resolveAsHashedUrl needs a from argument instead of using path.dirname(this.name) directly since it would depend on from where this is being called. A dependency might be referred by multiple sources.

BYK commented 10 years ago

Also I think resolveAsHashedUrl needs a from argument instead of using path.dirname(this.name) directly since it would depend on from where this is being called.

Only this one remains. I've fixed the issue when using baseUrl and also upgraded the CSS library since we had slightly different outputs on Windows and Linux, causing tests to fail on one or the other.

BYK commented 10 years ago

@benvinegar - I've looked again and I think this is ready for prime time. Gonna merge after you give it a final review.