disqus / python-phabricator

Python bindings for Phabricator
Apache License 2.0
159 stars 66 forks source link

Make sure connection is closed cleanly after use #60

Closed jasonbcox closed 4 years ago

jasonbcox commented 5 years ago

Although the socket typically ends up closed before cleanup, this is not always the case, resulting in warnings like <...>/phabricator/__init__.py:248: ResourceWarning: unclosed <ssl.SSLSocket fd=3, ...>. This patch fixes that behavior to ensure the connection socket is closed before garbage collection begins.