search

disqus / python-phabricator

Python bindings for Phabricator
Apache License 2.0
159 stars 66 forks source link

Add default retry to phab APIs #68

Closed markjm closed 2 years ago

markjm commented 2 years ago

This change should harden these

I am less familiar with python development, so please let me know if I am missing something here or if you would prefer not to bake in a little extra network hardening

markjm commented 2 years ago

Were you running into network issues or is this pre-emptive hardening?

We run into occasional network issues due to our network infrastructure and general networking transient errors, so we are hoping to protect against those. Its almost always the case that retrying fixes the issue (implying it is transient network conditions), so figured we could bake it in

markjm commented 2 years ago

awesome! would you do me the honors of publishing a new version :)

thekashifmalik commented 2 years ago

awesome! would you do me the honors of publishing a new version :)

Done w/ phabricator==0.9.0