search

disruptek / nimph

Nim package hierarchy manager from the future 🧚
MIT License
159 stars 10 forks source link

when a user specifies no --nimblePath, don't crash when cloning #76

Closed disruptek closed 4 years ago

disruptek commented 4 years ago

Just because this configuration makes no sense doesn't mean we shouldn't handle it better than this (on nim 1.0.4):

$ nimph clone chroma
👭cloning git://github.com/treeform/chroma.git...
... into /home/adavidoff/git/nimph/deps/pkgs/chroma-#head
no path to /home/adavidoff/git/nimph/deps/pkgs/github-1.0.2
no path to /home/adavidoff/git/nimph/deps/pkgs/npeg-0.21.3
/home/adavidoff/git/nimph/src/nimph.nim(585) nimph
/home/adavidoff/git/nimph/deps/pkgs/cligen-#head/cligen.nim(584) runclone
/home/adavidoff/git/nimph/src/nimph.nim(423) cloner
/home/adavidoff/git/nimph/src/nimph/project.nim(756) relocateDependency
/home/adavidoff/git/nimph/src/nimph/project.nim(653) removeSearchPath
/home/adavidoff/git/nimph/src/nimph/config.nim(414) removeSearchPath
Error: unhandled exception: unable to compute $nimbledir [ValueError]