[BUG] 404 when trying to "Add as redirect" in "Failures"

ieteo commented 2 years ago

Describe the bug

The release 4.2.0 fixed the bug #300 when editing or removing path containing slashes from "Routes". Thank you!

However, the bug is still present when trying to "Add as redirect" from "Failures", which results in 404 error as described in #300

This bug is only present on Apache when the AllowEncodedSlashes is set to Off

git clone https://github.com/getkirby/starterkit.git
cd starterkit
composer require distantnative/retour-for-kirby

Create Dockerfile with following content
```
FROM php:8.1-apache
RUN a2enmod rewrite
```

Build image and run the container

docker build -t starterkit .
docker run -p 80:80 -v "$PWD":/var/www/html starterkit

Call a non-existent URL containing slashes e.g. http://localhost/sub/not-existing
Go to http://localhost/panel, create user and log in
Go to Rredirect > Failures and Add as redirect the previously called non-existent URL

Result: 404 Not Found from Apache

Note Removing path containing slashes under Failures also results in 404 error

modal opens up in order to add the path as redirect

distantnative commented 2 years ago

🙈

ieteo commented 2 years ago

I assume that changing this line:

to: const path = encodeURIComponent(row.path.replace(/\//g, "\x1D"));

would hopefully also fix it in FailuresTab

EDIT:

The above alone won fix the issue.

In order to fix it, I had to changed the above and also change this line:

to: 'from' => str_replace("\x1D",'/', urldecode($path))

distantnative commented 2 years ago

✅