search

distantnative / retour-for-kirby

Kirby CMS plugin to manage redirects and track 404s right from the Panel
https://distantnative.com/retour-for-kirby/
MIT License
135 stars 15 forks source link

index.js in released v 4.3.0 doesn't contain the #308 fix for 404 in Failures tab #310

Closed ieteo closed 2 years ago

ieteo commented 2 years ago

Describe the bug

The compiled file index.js in released version 4.3.0 doesn't contain the #308 fix, related to #307

Presumably something went wrong in the build process.

Looking at the compiled index.js in release v4.3.0 and searching for encodeURIComponent

Reveals:

a=encodeURIComponent(t.from.replace(/\//g,"")); e=encodeURIComponent(t.path);

However, the compiled index.js should contain:

a=encodeURIComponent(t.from.replace(/\//g,"")); e=encodeURIComponent(t.path.replace(/\//g,""));

Steps to reproduce

  1. git clone https://github.com/distantnative/retour-for-kirby.git
  2. cd /retour-for-kirby
  3. npm install
  4. npm run build
  5. Search for encodeURIComponent in the freshly compiled index.js reveals the expected:

a=encodeURIComponent(t.from.replace(/\//g,"")); e=encodeURIComponent(t.path.replace(/\//g,""));

Additional context

Looking at the history of the index.js we can see the release 4.3.0 contains older index.js

Kind regards eteo