search

distatus / battery

cross-platform, normalized battery information library
MIT License
249 stars 36 forks source link

Add NotCharging state #26

Closed denysvitali closed 1 year ago

denysvitali commented 2 years ago

Check #16 for the details. Opened a new PR because the previous one was a PR from the master branch instead of the feature branch.

lyda commented 1 year ago

Is this going to get merged?

KenjiTakahashi commented 1 year ago

Not in the current form, sorry. Please see comments in #16 for more context. I am back to this code now and I'm nearly finished. Think just need to polish few things for OpenBSD (I must have had a really bad day writing this one, the code is... not great) and Solaris. And get my hands on a x86 machine, testing this library on an M1 MacBook is borderline impossible. Do not want to claim a timeline again, though. Last time I did, life decided soon after to crush all the plans I might have had 😕. [I am leaving this PR open for now, so people can find it easier if they need some solution that prevents crashing right now. Thanks for keeping it up!]

KenjiTakahashi commented 1 year ago

I have pushed the rework to master now. It should fix this problem, along with some others. Please see #30 for more details. Thanks again for keeping it up in the meantime!