Revamp Gravity Forms

[falconmick]

To be done after Apollo GraphQL PR

Issues with current forms:

A. Don't support custom/advanced fields (i.e. Name, you can configure to ask for First, Last, Middle, etc) B. Field implementation are not flexible enough. Currently I see myself and Mark having to re-write the Field implementations to match how we like our form element structure to look. A better solution would be a smart component that orchestrated a dumb component via render props. That way we could follow the pattern shown here in which you have your Form ( in the example) that lets you pass components in. Your custom component is wrapped in the smart component container (<components.MenuList {...props}>) which if it doesn't need to control the component just lets you wrap it in there OR if the smart container needs to control it (i.e. show/hide a required star) then you do the following (see next comment):

for more info on render props see react docs: https://reactjs.org/docs/render-props.html

Open for more ideas to make this better/feedback on my ideas.

falconmick commented 6 years ago

    <components.MenuList {...props} renderRequired={(props) => {
           return <span>*</span>
      }}>
      <div style={menuHeaderStyle}>
        Custom Menu List
      </div>
      {props.children}
    </components.MenuList>

falconmick commented 6 years ago

Also This package has some really good ideas put into it and is worth digging into: https://deploy-preview-2289--react-select.netlify.com/home it's the v2 beta of react-select

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[falconmick]

    <components.MenuList {...props} renderRequired={(props) => {
           return <span>*</span>
      }}>
      <div style={menuHeaderStyle}>
        Custom Menu List
      </div>
      {props.children}
    </components.MenuList>

[falconmick]

Also This package has some really good ideas put into it and is worth digging into: https://deploy-preview-2289--react-select.netlify.com/home it's the v2 beta of react-select