distillpub / post--building-blocks

The Building Blocks of Interpretability
https://distill.pub/2018/building-blocks
Creative Commons Attribution 4.0 International
87 stars 27 forks source link

In teaser image, hovering over spatial locations doesn't change the feature visualization #17

Closed kai-qu closed 6 years ago

kai-qu commented 6 years ago

The interface design figure says: "For instance, let us consider our teaser figure again. (...) hovering over spatial locations gives us neuron-specific attribution." Perhaps I misunderstood the caption, but the figure shows a bidirectional arrow between image and feature visualization, so I thought hovering over the image would change the feature visualization, but it doesn't seem to change anything. Here's what I see:

distill

Using Chrome on macOS. No obvious console errors.

ludwigschubert commented 6 years ago

@hypotext you're right—we removed this feature pretty much last minute as the attribution wasn't normalized and so all the values where too small to really see. @arvind is probably best suited to decide what we should do here—either remove the text mentioning it, or add back the feature (it's just disabled through CSS) and rethink how we display the magnitudes in a humanely meaningful way.

arvind commented 6 years ago

Thanks @hypotext. Fixed with 46dbec6 to make the teaser design space diagrams to reflect the final behavior of the teaser figure. As @ludwigschubert mentioned, we got rid of the neuron attribution because they were incorrect (and tedious to recompute).