search

distillpub / post--communicating-with-interactive-articles

https://distill.pub/2020/communicating-with-interactive-articles
Creative Commons Attribution 4.0 International
38 stars 15 forks source link

Fixed reference: 'Drawing Dynamic Visualizations' -> 'Interactive Exploration of a Dynamical System' #30

Closed joshuahhh closed 1 year ago

joshuahhh commented 1 year ago

I noticed what seemed to be a mistaken reference to "Drawing Dynamic Visualizations". I messaged @mathisonian, who agreed, suggested "Interactive Exploration of a Dynamical System" as a replacement, and asked me to make a PR.

I ran npm run build, and things look good. This PR might need a bit of scrutiny though.

In particular: When I pulled the repo, it failed to build, reporting broken imports of various files in static. These files appeared to actually be in public. I fixed this, and it builds now. This feels strange though, since (presumably) people were building this fine before me. Please double-check that this is reasonable. (I don't understand why static exists.)

Thanks!

fredhohman commented 1 year ago

Good catch @joshuahhh! I agree with the citation change.

The weird static and public issue stems from the original Distill template, and in the webpack config it copies everything from static to public (I'm not sure why it was set up like this). I've replaced the one other place we used static (66e3031c692699230f3245cf39e5a88278cd897d) and removed that folder from the repo now.

fredhohman commented 1 year ago

I merged this, but FYI I don't know when it will appear on Distill live!