distillpub / post--feature-wise-transformations

Feature-Wise Transformations
https://distill.pub/2018/feature-wise-transformations
Creative Commons Attribution 4.0 International
20 stars 11 forks source link

Style interpolation figures do not display #191

Closed ethanjperez closed 6 years ago

ethanjperez commented 6 years ago

It may be just for me, but the style interpolation figures do not display (only the toggle bars).

Here is what I see:

image

vdumoulin commented 6 years ago

I realized I forgot to push some changes. Can you pull and tell me if you are still experiencing the issue?

harm-devries commented 6 years ago

+1 Still experiencing this issue :(

Edit: Actually, it worked when I refreshed the page. In general, some of the images are not always loading properly (for example the top two ones). I'll see if I can track down the bug Edit2: probably related to the following warning Controller received DOMContentLoaded before appropriate document.readyState!. Page is rendered before all images are loaded.

ethanjperez commented 6 years ago

Still experiencing an issue as well (random images or pairs of images will not display, usually including the one image that's supposed to be highlighted during the interpolation):

image

ethanjperez commented 6 years ago

Also, what about switching to something more compact/concise, as in the AIA Distill article? image

Could fit both interpolations in one line, and the click-and-drag style interpolation I found easier (and actually pretty fun) to play around with; it requires less hand-eye coordination than the hovering mechanism.

Could probably also use the code from that article, so we'd also not have to debug any issues with the current interactive figure.

fstrub95 commented 6 years ago

I kind of like Ethan idea!

fstrub95 commented 6 years ago

Quick question, when is the deadline again :)

ethanjperez commented 6 years ago

This Friday!