distillpub / post--feature-wise-transformations

Feature-Wise Transformations
https://distill.pub/2018/feature-wise-transformations
Creative Commons Attribution 4.0 International
19 stars 10 forks source link

Thoughts on Present Version #222

Closed colah closed 6 years ago

colah commented 6 years ago

Hi All!

I just went over the article again. It's looking great! I had a few small comments. Note that these aren't Distill editorial feedback, and you aren't obligated to take any of it.

image

image

image

image

(A couple other thoughts: consider making it possible to hover over the labels rather than just the circles in the legend.)

image

vdumoulin commented 6 years ago

@colah thanks a lot for your feedback!

I'll address it gradually over time, but I think you identified one pressing issue: the Charade still frame. I'm glad that you pointed it out, as I hadn't realized that it could come off as making a gender stereotype (which in hindsight I should have caught sooner). Needless to say, this is definitely not our intention, so I'll find a replacement ASAP.

arvind commented 6 years ago

The last t-SNE plot seems like it might be broken on drafts (but maybe you've already fixed it and it hasn't rebuilt?)

Aha, I tracked down why this is broken online but working locally.

image

@vdumoulin, I believe github.io supports https (https://ariutta.github.io/svg-pan-zoom/dist/svg-pan-zoom.min.js resolves for me). Alternatively, you could copy the js library into your static folder and reference it from there. I may have a slight preference for the latter to increase future proofing.

colah commented 6 years ago

A few more thoughts:

image

image

or

image

fstrub95 commented 6 years ago

to fix the https bug, we can either install the package with npm (I anticipated this scenario in the code) or copy past the jascript in public.

To use with browserify, follow these steps:

On a different point, the image mask on clevr (interpolation) does not work on firefox. but i do not know how to fix it

On Fri, Jun 29, 2018, 11:44 PM Arvind Satyanarayan notifications@github.com wrote:

The last t-SNE plot seems like it might be broken on drafts (but maybe you've already fixed it and it hasn't rebuilt?)

Aha, I tracked down why this is broken online but working locally.

[image: image] https://user-images.githubusercontent.com/42262/42116075-9ab164e4-7baa-11e8-8a38-947958c663a8.png

@vdumoulin https://github.com/vdumoulin, I believe github.io supports https (https://ariutta.github.io/svg-pan-zoom/dist/svg-pan-zoom.min.js resolves for me). Alternatively, you could copy the js library into your static folder and reference it from there. I may have a slight preference for the latter to increase future proofing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vdumoulin/distill-film/issues/222#issuecomment-401481850, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvzhBkKFaaNcboDG-tKB-5XOkjZDTg7ks5uBp_RgaJpZM4U9j6X .

vdumoulin commented 6 years ago

@colah here are new figure designs following your feedback:

image

image

image

image

image

colah commented 6 years ago

Looks nice! :)