Closed colah closed 6 years ago
@colah thanks a lot for your feedback!
I'll address it gradually over time, but I think you identified one pressing issue: the Charade still frame. I'm glad that you pointed it out, as I hadn't realized that it could come off as making a gender stereotype (which in hindsight I should have caught sooner). Needless to say, this is definitely not our intention, so I'll find a replacement ASAP.
The last t-SNE plot seems like it might be broken on drafts (but maybe you've already fixed it and it hasn't rebuilt?)
Aha, I tracked down why this is broken online but working locally.
@vdumoulin, I believe github.io supports https (https://ariutta.github.io/svg-pan-zoom/dist/svg-pan-zoom.min.js resolves for me). Alternatively, you could copy the js library into your static
folder and reference it from there. I may have a slight preference for the latter to increase future proofing.
A few more thoughts:
or
to fix the https bug, we can either install the package with npm (I anticipated this scenario in the code) or copy past the jascript in public.
To use with browserify, follow these steps:
Require svg-pan-zoom in your source file svgPanZoom = require('svg-pan-zoom')
source:https://github.com/ariutta/svg-pan-zoom/blob/master/README.md
On a different point, the image mask on clevr (interpolation) does not work on firefox. but i do not know how to fix it
On Fri, Jun 29, 2018, 11:44 PM Arvind Satyanarayan notifications@github.com wrote:
The last t-SNE plot seems like it might be broken on drafts (but maybe you've already fixed it and it hasn't rebuilt?)
Aha, I tracked down why this is broken online but working locally.
[image: image] https://user-images.githubusercontent.com/42262/42116075-9ab164e4-7baa-11e8-8a38-947958c663a8.png
@vdumoulin https://github.com/vdumoulin, I believe github.io supports https (https://ariutta.github.io/svg-pan-zoom/dist/svg-pan-zoom.min.js resolves for me). Alternatively, you could copy the js library into your static folder and reference it from there. I may have a slight preference for the latter to increase future proofing.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vdumoulin/distill-film/issues/222#issuecomment-401481850, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvzhBkKFaaNcboDG-tKB-5XOkjZDTg7ks5uBp_RgaJpZM4U9j6X .
@colah here are new figure designs following your feedback:
Looks nice! :)
Hi All!
I just went over the article again. It's looking great! I had a few small comments. Note that these aren't Distill editorial feedback, and you aren't obligated to take any of it.
I was skeptical about the collapsible sections, but I'm coming around! :)
While rereading, I was struck that the video example from Charade could potentially be perceived as making a gender stereotype (ie. "women are prone to nervous breakdowns"). I feel like I'm not super calibrated on this kind of thing, and I realize you're working in a lot of constraints, like making it public domain and that you already had to switch it once before... But if it's convenient to swap out, you might consider doing so.
(A couple other thoughts: consider making it possible to hover over the labels rather than just the circles in the legend.)