search

distillpub / post--feature-wise-transformations

Feature-Wise Transformations
https://distill.pub/2018/feature-wise-transformations
Creative Commons Attribution 4.0 International
19 stars 10 forks source link

(WIP) Adjust style interpolation diagram to address @colah suggestions #228

Closed nschuc closed 6 years ago

nschuc commented 6 years ago

Wait for images to merge

This PR adjusts layout of style interpolation figure as per @colah's design.

@vdumoulin will generate images for the different combinations of style/content images.

screen shot 2018-07-04 at 4 57 20 pm

colah commented 6 years ago

Sweet! I think this will be a much richer way for your readers to explore the interactions. It also allows them to see the interpolation even if they're just skimming or the paper gets printed. :)

vdumoulin commented 6 years ago

@nschuc Thanks, the redesign looks fantastic! 😄I just pushed a commit to origin/nathan_redesign_style_interpolation with the missing images:

image

One small nitpick before we merge: the SVG width is set to 1000, but the "natural" width for a figure of class l-body-outset should be 888. Can you change the width to 888 and adjust the sizes and positions so your figure layout fits within that width?

The main reason for this is to have the text sizes look consistent from one figure to another throughout the article.