search

distillpub / post--momentum

Why Momentum Really Works
https://distill.pub/2017/momentum/
Creative Commons Attribution 4.0 International
197 stars 51 forks source link

Some wrong formulas #102

Open emanuel-sygal opened 5 years ago

emanuel-sygal commented 5 years ago

E.g. the equation for R^k has the indices of R_2 and R_1 swapped.

shmulib commented 1 year ago

I think what @emanuel-sygal means by this is the formula for Rj is wrong.

It should be R_1 = (R - sigma_2)/(sigma1-sigma2) and R_2 = (R - sigma_1)/(sigma1-sigma2) and not R_j = (R-sigma_j)/(sigma_1 - sigma_2).

This stumped me for a while. With the incorrect formula the initial condition of x_i_0, y_i_0 = 1, 1 isn't satisfied.

Thanks so much for the excellent article in general though, this is really topic quality exposition