project cleanup - Githubissues

distributePro / ovsrpro

A collection of 3rd party libraries.

MIT License

0 stars 4 forks source link

project cleanup #38

Closed smanders closed 6 years ago

smanders commented 6 years ago

remove unnecessary mkpatch, download, and patch functions

there's very rarely a reason to implement functions for each of the steps anymore, externpro is smart enough now to use variables defined in the PRO_${PRO} definition

mkpatch -- xpCloneProject()
download -- xpDownloadProject()
patch -- xpPatchProject() https://github.com/smanders/externpro/blob/18.01.1/modules/macpro.cmake#L161-L178

this removes the need to use some of the cmake functions that were intended only to be used internally by externpro (those that start with the ip prefix) https://github.com/smanders/externpro/blob/18.01.1/modules/xpfunmac.cmake#L4

smanders commented 6 years ago

fix DLURL

two projects (glew and qwt) are naming their download download -- the DLURL is from sourceforge and could be fixed so this works correctly

use DLNAME

two other projects (cppzmq and zeromq) are naming their download v4.2.1.tar.gz and v4.2.2.tar.gz -- they both download directly from github -- they could both use DLNAME to use more meaningful names