distributePro / ovsrpro

A collection of 3rd party libraries.
MIT License
0 stars 4 forks source link

upgrade to externpro 18.04.1 #44

Closed brobeson closed 6 years ago

brobeson commented 6 years ago

closes #43

This also closes #16. When I run CMake to build ovsrpro using externpro 18.04.1, the projects readme file doesn't change.

brobeson commented 6 years ago

how on earth does this close issue 16?

Recall that in #37, @smanders commented that the readme fixes for HDF5, NOVAS, and Qwt required that "ovsrpro uses the not-yet-released-next-release of externpro (newer than 18.01.1)". I assume @smanders made a change to externpro in 18.04.1 which passively resolved #16. That is, the externpro change didn't require us to make a change in ovsrpro.

smanders commented 6 years ago

externpro 18.04.1 includes https://github.com/smanders/externpro/issues/162 which fixes the readme generation for ovsrpro

bnhhughes commented 6 years ago

approved (post) - been out at a field event...