Add normalized_name parameter automatically to Group, Item and Category

distributeaid / toolbox

DistributeAid Toolbox

http://distributeaid.org

GNU Affero General Public License v3.0

3 stars 1 forks source link

Add normalized_name parameter automatically to Group, Item and Category #94

Closed theodowling closed 3 years ago

theodowling commented 3 years ago

I've implemented as discussed on issue #22. Sorry for the delays. I've been struggling to get this running so that I can test it.

Please let me know if there is anything I need to change.

pedro-gutierrez commented 3 years ago

Hey thank you for this! I was wondering whether it makes sense to add a unique constraint on the normalised name. Eg So that we prevent from creating a category with a name "clothes" if another one with name "Clothes" already exists. Other than that I think the code looks really neat and happy to approve and merge it.

theodowling commented 3 years ago

Hi @pedro-gutierrez - very happy with adding that. I had the same thought this morning 👍

theodowling commented 3 years ago

Thanks. I will make these updates today. Will you be able to add the hacktoberfest-accepted label to this PR?

pedro-gutierrez commented 3 years ago

Just merged. Thank you so much for your help on this!