distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

pprof-datalog only supports OSE...should also support origin. #158

Open jeremyeder opened 8 years ago

jeremyeder commented 8 years ago

Only the service names and /etc/sysconfig locations differ. They should be conditionalized. /cc @ekuric

diff -pruN /opt/pbench-agent/tool-scripts/datalog/pprof-datalog.orig /opt/pbench-agent/tool-scripts/datalog/pprof-datalog

--- /opt/pbench-agent/tool-scripts/datalog/pprof-datalog.orig 2016-02-09 12:29:38.079425999 -0500 +++ /opt/pbench-agent/tool-scripts/datalog/pprof-datalog 2016-02-09 12:30:17.701923330 -0500 @@ -1,7 +1,7 @@

!/usr/bin/env bash

-openshift_master="/etc/sysconfig/atomic-openshift-master" -openshift_node="/etc/sysconfig/atomic-openshift-node" +openshift_master="/etc/sysconfig/origin-master" +openshift_node="/etc/sysconfig/origin-node"

profile="$1" osecomponent="$2" @@ -12,18 +12,18 @@ ose_pprof() { case "$profile" in cpu) if grep -q "^OPENSHIFT_PROFILE=cpu" $openshift_master; then

ekuric commented 8 years ago

@jeremyeder I will fix this.

ashishkamra commented 7 years ago

@ekuric still planning to work on this? @sjug is this required since you are reworking pprof?