search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
186 stars 108 forks source link

Is there anything in the ssh config files that should be scrubbed? #1630

Open ndokos opened 4 years ago

ndokos commented 4 years ago

PR #1616 captures the ssh config files from ${HOME}/.ssh/config /etc/ssh/ssh_config and /etc/ssh_config.d/* into the pbench-agent tarball.

N.B. Currently pbench-agent runs as root so $HOME == /root.

Is there anything in there that should be scrubbed?

portante commented 4 years ago

This is possibly, but we have already run as root and we have entire sosreports collected as root. This seems like it would be part of a general problem of scrubbing collected data. The collected data only needs to be scrubbed if it leaves a given domain.