search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

indexer.py user benchmark intake #1798

Open dbutenhof opened 4 years ago

dbutenhof commented 4 years ago

In _make_user_benchmark_json we should be constructing a data sample using the "driver" information extracted from known_user_benchmarks.

Right now, the base_sample_md dict is hardcoded to use "measurement_type", "number" even though our "driver" dict contains the actual type defined by known_user_benchmarks.

Right now, "Hammberdb-tpcc" is the only user benchmark type, and the type of the "Tbc" val_col is defined as "long" (corresponding to number); when we generalize the user benchmark code, this will need to be fixed... right now it's a nit that would make the code seem a bit cleaner.

portante commented 2 years ago

I need to review the current state of the existing work.