[BUG] PR #2782 removed deprecated bench scripts but did not fix the agent Makefile to remove them

ndokos commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Description

agent/Makefile still includes the deleted bench script.s

To Reproduce

   cd agent/rpm
   make

Actual Results

The result is

...
install --directory /tmp/opt/pbench-agent-0.72.0/agent/bench-scripts/templates
cd bench-scripts; \
    cp -a pbench-cyclictest pbench-dbench pbench-fio pbench-fio.md pbench-gen-iterations pbench-iozone pbench-linpack pbench-migrate pbench-netperf pbench-run-benchmark pbench-run-benchmark.pl pbench-run-benchmark-sample pbench-specjbb2005 pbench-uperf pbench-uperf.md pbench-user-benchmark templates /tmp/opt/pbench-agent-0.72.0/agent/bench-scripts
/home/nick/src/pbench/github/pbench/worktrees/python3-devel/agent/bench-scripts
cp: cannot stat 'pbench-cyclictest': No such file or directory
cp: cannot stat 'pbench-dbench': No such file or directory
cp: cannot stat 'pbench-iozone': No such file or directory
cp: cannot stat 'pbench-migrate': No such file or directory
cp: cannot stat 'pbench-netperf': No such file or directory
make[1]: *** [Makefile:276: install-bench-scripts] Error 1
make[1]: Leaving directory '/home/nick/src/pbench/github/pbench/worktrees/python3-devel/agent'
make: *** [../../utils/rpm.mk:68: agent] Error 2
...

Expected Results

Successful creation of (s)rpm.

Additional information

No response

portante commented 2 years ago

PR #2803 adds a test to catch this kind of failure in the CI.