search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

Retire the previous containerized Agent example from contrib #3384

Closed webbnh closed 1 year ago

webbnh commented 1 year ago

The recently added pbench and pbench_demo files in contrib/containerized-pbench/ now encompass the previous example which was there. This PR removes the files associated with the previous example and updates the README.md file.

(Also, my IDE has acquired a new bash linter, and so I made some small tweaks to the pbench_demo to shut it up.)

webbnh commented 1 year ago

The changes to #3383 collided with the changes I made in response to Dave's comment above, so I removed them from my branch during the rebase, ~which, interestingly, did not revoke Dave's approval~ [yes, it did, ~but the big green checkmark still shows by Dave's entry~ ah, the wonders of revisionist history...].

(But, Smee hasn't poked Mr. Jenkins about this, yet...I'm hoping that posting this comment will make that happen....)

dbutenhof commented 1 year ago

The changes to #3383 collided with the changes I made in response to Dave's comment above, so I removed them from my branch during the rebase, ~which, interestingly, did not revoke Dave's approval~ [yes, it did, ~but the big green checkmark still shows by Dave's entry~ ah, the wonders of revisionist history...].

(But, Smee hasn't poked Mr. Jenkins about this, yet...I'm hoping that posting this comment will make that happen....)

The bad news is ... it doesn't really matter much at this time.

Someone has completely removed the npmjs.com package for keycloak-masthead, which is a dependency of the keycloak-js package we use. All our builds are failing and will continue to fail until either keycloak-js stops depending on it, keycloak-masthead is restored, or we stop depending on keycloak-js (which I believe we really don't want to do).

So for now, Jenkins builds are gone. 😦

webbnh commented 1 year ago

Someone has completely removed the npmjs.com package for keycloak-masthead, which is a dependency of the keycloak-js package we use. All our builds are failing and will continue to fail until either keycloak-js stops depending on it, keycloak-masthead is restored, or we stop depending on keycloak-js (which I believe we really don't want to do).

The keycloak/keycloak-ui repo (which was archived today) says

The keycloak-ui repo has been merged into the /js directory of the Keycloak repository. Please open any new issues and PRs on that repository.

So...hopefully, we're just in some sort of transition and we're waiting for a build or a cache or something to flush....

webbnh commented 1 year ago

According to npmjs.com, the keycloak-js package was updated 6 hours ago to v21.1.0 (from v21.0.2).

dbutenhof commented 1 year ago

According to npmjs.com, the keycloak-js package was updated 6 hours ago to v21.1.0 (from v21.0.2).

Yes, that's the broken package. 21.1.0-1 is now up with a fix, even though the associated PR #19811 isn't merged yet. If I'd just been a minute slower in working around it, everything would have been fine. (Sigh.) 😆