search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

Build pbench-tools-kill - Backport of #3405 to b0.72 #3408

Closed ndokos closed 1 year ago

ndokos commented 1 year ago

Fixes #3404

Add pbench-tools-kill to the click commands in the agent Makefile.

dbutenhof commented 1 year ago

The failures are ... weird. But they make me wonder if we need to cherry-pick my Flask/Werkzeug requirements.txt changes back to b0.72. 😦 Although the signature is bizarre and somewhat different, it's possible that Flask 2.3.1 did partially resolve the issues causing a less direct failure mode.

dbutenhof commented 1 year ago

OK, now I don't know what to think. I don't see these on a local branch pulled from b0.72, with Flask 2.3.1 and Werkzeug 2.3.1. Since your build however used Werkzeug 2.3.0 ... it's possible they just published a fix. I'm going to re-submit the build.

webbnh commented 1 year ago

The working case used Werkzeug==2.3.1 while the failing case used Werkzeug==2.3.0 (all other versions looked the same)...so perhaps we can uncap Flask and Werkzeug on main now?

dbutenhof commented 1 year ago

The working case used Werkzeug==2.3.1 while the failing case used Werkzeug==2.3.0 (all other versions looked the same)...so perhaps we can uncap Flask and Werkzeug on main now?

You might take a look at #3409, which has been up for an hour. 😁

webbnh commented 1 year ago

You might take a look at #3409, which has been up for an hour. 😁

Just did. (I'm working in chronological sequence...relative things like "an hour" are meaningless.... 🙃)