search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

[BUG] v0.72.0 Using labels with `pbench-register-tool` is broken #3454

Closed ndokos closed 1 year ago

ndokos commented 1 year ago

Is there an existing issue for this?

Description

If a tool is registered on a host with a label:

pbench-register-tool --name=vmstat --label=foo

there is a warning when postprocessing results:

# pbench-user-benchmark -- sleep 10
Running sleep 10 for iteration 1-default
[warn][2023-06-07T12:07:48.723985869] [pbench-postprocess-tools] Missing tool output directory, '/var/lib/pbench-agent/pbench-user-benchmark__2023.06.07T12.07.34/1-default/sample1/tools-default/dhcp31-111.perf.lab.eng.bos.redhat.com'
Collecting system information
...

The reported tool output directory is indeed missing. The actual tool output directory is /var/lib/pbench-agent/pbench-user-benchmark__2023.06.07T12.07.34/1-default/sample1/tools-default/foo:dhcp31-111.perf.lab.eng.bos.redhat.com and that exists, but pbench-postprocess-tools does not use the label when constructing the path. Indeed, it cannot currently because pbench-list-tools (whose output is used by pbench-postprocess-tools to enumerate hosts, tools and options) is currently incapable of producing the labels info.

To Reproduce

See above.

Actual Results

See above.

Expected Results

See above.

Additional information

No response