search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

v0.72.0: Fix handling of labeled hosts by pbench-postprocess-tools #3456

Closed ndokos closed 1 year ago

ndokos commented 1 year ago

Fixes #3454

pbench-postprocess-tools mishandles hosts with labels (added by tool registration commands): it ignores the label and complains that it cannot find the tool output directory. The tool output directory path contains <label>:<host> as one element in the path but pbench-postprocess-tools looks for a <host> element.

pbench-postprocess-tools parses the output of pbench-list-tools to get the tool info it needs, but pbench-list-tools omits the label from its output.

The first commit fixes pbench-list-tools to add the label to its output and pbench-postprocess-tools to parse that output, derive the label and use it to construct the path of the tool output directory.

The second commit deals with tests.

PBENCH-1178

ndokos commented 1 year ago

I saw the breakage and figured I'd backport it (in the modified form that @webbnh mentioned in #3455). It worked, so yeah, maybe we can just keep it. Or I can back it out if necessary , although I hope to leave b0.72 behind very soon after the release is out :smile:

ndokos commented 1 year ago

I dropped the React commit (that's the only change). We'll see what Jenkins thinks.