This is the latest round of nits and stuff that I've accumulated. It is broken into separate commits to make it easier to review.
Most of the changes are picking lint:
in particular renaming variables to avoid using keywords or shadowing variables and other names already defined in an outer scope (particularly request, throughout the ApiBase hierarchy)
converting methods to @staticmethod where appropriate
adding variable initializations to quiet use-before-initialization warnings
fixing typos, missing comments, etc.
Some small code-quality and comment improvements
Replacing Python V2-style string interpolation with V3 "f-strings" or str.format() calls; rewrapping certain long strings at more logical break-points
Fixing a couple of logging statements in the indexer which result in errors due to their formatting
This is the latest round of nits and stuff that I've accumulated. It is broken into separate commits to make it easier to review.
request, throughout theApiBasehierarchy)@staticmethodwhere appropriatestr.format()calls; rewrapping certain long strings at more logical break-points